Mac OS X 10.5 compiler fixes #1523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deledrius
approved these changes
Nov 5, 2023
dgelessus
reviewed
Nov 5, 2023
This is missing from older versions of Apple's OpenAL.framework headers. We check if it's supported before trying to use it, but it does need to be defined.
dpogue
force-pushed
the
osx-10.5-fixes
branch
2 times, most recently
from
e8c60d5 to
aebf1a9
Compare
dgelessus
approved these changes
Nov 5, 2023
Hoikas
reviewed
Nov 5, 2023
| // but clock_gettime exists since macOS 10.12. | ||
| int res = clock_gettime(CLOCK_REALTIME, &ts); | ||
| hsAssert(res == 0, "clock_gettime failed"); | ||
| # if defined(HAVE_BUILTIN_AVAILABLE) && MAC_OS_X_VERSION_MIN_REQUIRED >= 101500 |
There was a problem hiding this comment.
Suggested change
| # if defined(HAVE_BUILTIN_AVAILABLE) && MAC_OS_X_VERSION_MIN_REQUIRED >= 101500 | |
| #if defined(HAVE_BUILTIN_AVAILABLE) && MAC_OS_X_VERSION_MIN_REQUIRED >= 101500 |
| int res = timespec_get(&ts, TIME_UTC); | ||
| hsAssert(res != 0, "timespec_get failed"); | ||
| } else | ||
| # endif |
There was a problem hiding this comment.
Suggested change
| # endif | |
| #endif // defined(HAVE_BUILTIN_AVAILABLE) && MAC_OS_X_VERSION_MIN_REQUIRED >= 101500 |
Co-Authored-By: dgelessus <[email protected]>
The file was ifdef'ed out on non-Windows platforms, but it sometimes causes linker warnings about the file having no symbols. Better to just avoid compiling/linking it entirely on non-Windows platforms.
dpogue
force-pushed
the
osx-10.5-fixes
branch
from
aebf1a9 to
cba2861
Compare
Hoikas
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a full set of changes to make everything build on 10.5 PowerPC (because everything does not build on 10.5 PowerPC) but this is a hopefully uncontroversial set of small fixes.